[PATCH] drm/amdgpu: stop touching bo->tbo.ttm

Felix Kuehling felix.kuehling at amd.com
Fri Aug 7 15:06:39 UTC 2020


Am 2020-08-07 um 8:33 a.m. schrieb Christian König:
> This is not allocated any more for SG BOs.
Can you point me at the relevant TTM changes that require this change?

We'd need to test that the SG BO is still working as expected. A
doorbell self-ring test or a GPU HDP flush test in KFDTest should do the
trick.

Regards,
  Felix


>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 9015c7b76d60..2470b913038b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1232,10 +1232,8 @@ int amdgpu_amdkfd_gpuvm_alloc_memory_of_gpu(
>  				domain_string(alloc_domain), ret);
>  		goto err_bo_create;
>  	}
> -	if (bo_type == ttm_bo_type_sg) {
> +	if (bo_type == ttm_bo_type_sg)
>  		bo->tbo.sg = sg;
> -		bo->tbo.ttm->sg = sg;
> -	}
>  	bo->kfd_bo = *mem;
>  	(*mem)->bo = bo;
>  	if (user_addr)


More information about the amd-gfx mailing list