[PATCH 4/4] drm/amdgpu/pm: only hide average power on SI and pre-RENOIR APUs

Nirmoy nirmodas at amd.com
Tue Aug 18 08:30:27 UTC 2020


Series is Acked-by: Nirmoy Das <nirmoy.das at amd.com>

On 8/17/20 9:53 PM, Alex Deucher wrote:
> We can get this on RENOIR and newer via the SMU metrics
> table.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/pm/amdgpu_pm.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index f2e70655e8d9..a77f7347fdfc 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -3312,12 +3312,17 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj,
>   
>   	if (((adev->flags & AMD_IS_APU) ||
>   	     adev->family == AMDGPU_FAMILY_SI) &&	/* not implemented yet */
> -	    (attr == &sensor_dev_attr_power1_average.dev_attr.attr ||
> -	     attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr ||
> +	    (attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr ||
>   	     attr == &sensor_dev_attr_power1_cap_min.dev_attr.attr||
>   	     attr == &sensor_dev_attr_power1_cap.dev_attr.attr))
>   		return 0;
>   
> +	if (((adev->family == AMDGPU_FAMILY_SI) ||
> +	     ((adev->flags & AMD_IS_APU) &&
> +	      (adev->asic_type < CHIP_RENOIR))) &&	/* not implemented yet */
> +	    (attr == &sensor_dev_attr_power1_average.dev_attr.attr))
> +		return 0;
> +
>   	if (!is_support_sw_smu(adev)) {
>   		/* hide max/min values if we can't both query and manage the fan */
>   		if ((!adev->powerplay.pp_funcs->set_fan_speed_percent &&


More information about the amd-gfx mailing list