[PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd

Nirmoy nirmodas at amd.com
Mon Aug 31 14:59:56 UTC 2020


Hi Alex,

On 8/31/20 4:17 PM, Alex Deucher wrote:
> On Mon, Aug 31, 2020 at 6:41 AM Nirmoy Das <nirmoy.das at amd.com> wrote:
>> UVD dependent jobs should run on the same udv instance.
>> This patch disables gpu scheduler's load balancer for
>> a context which binds jobs from same the context to a udv
>> instance.
> typos: udv -> uvd
> With that fixed:
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>
> Does VCE need a similar fix?  What about UVD_ENC?


I am not sure, can you please confirm this.


Nirmoy



>
> Alex
>
>
>> Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> index 59032c26fc82..7cd398d25498 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> @@ -114,7 +114,9 @@ static int amdgpu_ctx_init_entity(struct amdgpu_ctx *ctx, u32 hw_ip,
>>          scheds = adev->gpu_sched[hw_ip][hw_prio].sched;
>>          num_scheds = adev->gpu_sched[hw_ip][hw_prio].num_scheds;
>>
>> -       if (hw_ip == AMDGPU_HW_IP_VCN_ENC || hw_ip == AMDGPU_HW_IP_VCN_DEC) {
>> +       if (hw_ip == AMDGPU_HW_IP_VCN_ENC ||
>> +           hw_ip == AMDGPU_HW_IP_VCN_DEC ||
>> +           hw_ip == AMDGPU_HW_IP_UVD) {
>>                  sched = drm_sched_pick_best(scheds, num_scheds);
>>                  scheds = &sched;
>>                  num_scheds = 1;
>> --
>> 2.28.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cnirmoy.das%40amd.com%7C6a3e9061d2f043783ea408d84db8a04e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637344802648079859&sdata=C7lkg97j7F6Kq1Vz7L79TbEDvfQm8QS3PUhdHfQ3Rcs%3D&reserved=0


More information about the amd-gfx mailing list