[PATCH] drm/amd: print error on convert_tiling_flags_to_modifier failure

[Michel Dänzer]

On 2020-12-04 1:01 p.m., Simon Ser wrote:
> On Friday, December 4, 2020 12:52 PM, Michel Dänzer <michel at daenzer.net> wrote:
> 
>> This should be either a debugging message disabled by default, or
>> rate-limited somehow, or user-space can spam dmesg.
> 
> Hm. I just mimicked what amdgpu_display_user_framebuffer_create is
> doing here:
> 
>      dev_err(&dev->pdev->dev, "No GEM object associated to handle 0x%08X, "
>              "can't create framebuffer\n", mode_cmd->handles[0]);
> 
> But yeah DRM_DEBUG_KMS would probably be more appropriate here. Maybe
> makes sense to change dev_err to DRM_DEBUG_KMS in
> amdgpu_display_user_framebuffer_create as well? I believe user-space
> can trigger that one at will too.

There are probably many more bad examples in existing code. The 
important thing is not to add more. :)


-- 
Earthling Michel Dänzer               |               https://redhat.com
Libre software enthusiast             |             Mesa and X developer