[PATCH] drm/amdgpu: add the missing AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag

[Christian König]

The flag is set by the kernel when it detects that contiguous VRAM is 
necessary by because of some hardware restriction. It should never be 
set by userspace manually.

I've added giant page optimizations as a best effort handling which 
atomatically kicks in when enough VRAM is available. If VRAM is 
fragmented we fall back to huge page allocations.

Regards,
Christian.

Am 08.12.20 um 11:28 schrieb Chen Lei:
> Hi! I am not quite familiar with it, and I was wondering why this flag is blocked. As the VM subsystem supports giant pages, it might be useful to add this flag in amdgpu_gem_create_ioctl.
>
>
> > -----原始邮件-----
> > 发件人: "Christian König" <ckoenig.leichtzumerken at gmail.com>
> > 发送时间: 2020-12-08 15:41:02 (星期二)
> > 收件人: "Chen Lei" <chenlei18s at ict.ac.cn>, alexander.deucher at amd.com, christian.koenig at amd.com
> > 抄送: amd-gfx at lists.freedesktop.org
> > 主题: Re: [PATCH] drm/amdgpu: add the missing AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag
> >
> > Am 08.12.20 um 03:50 schrieb Chen Lei:
> > > Add the AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag in amdgpu_gem_create_ioctl.
> > >
> > > Signed-off-by: Chen Lei <chenlei18s at ict.ac.cn>
> >
> > NAK, that is not missing but intentionally blocked.
> >
> > Christian.
> >
> > > ---
> > >   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > > index 7e8265da9..da18aeff7 100644
> > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > > @@ -233,6 +233,7 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
> > >   		      AMDGPU_GEM_CREATE_NO_CPU_ACCESS |
> > >   		      AMDGPU_GEM_CREATE_CPU_GTT_USWC |
> > >   		      AMDGPU_GEM_CREATE_VRAM_CLEARED |
> > > +		      AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS |
> > >   		      AMDGPU_GEM_CREATE_VM_ALWAYS_VALID |
> > >   		      AMDGPU_GEM_CREATE_EXPLICIT_SYNC |
> > >   		      AMDGPU_GEM_CREATE_ENCRYPTED))
> </chenlei18s at ict.ac.cn></chenlei18s at ict.ac.cn></ckoenig.leichtzumerken at gmail.com>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx