[PATCH] amdgpu: don't treat BAR resize failure due to unsupported requested size as an error

Darren Salt devspam at moreofthesa.me.uk
Wed Dec 9 18:55:40 UTC 2020


On the resize attempt failing with -EINVAL, instead report an informational
message indicating that the requested BAR size is not listed as supported by
the VBIOS.

Without this, as I have an RX 5600 XT which lists only 256MB, 512MB and
1024MB as supported, I see
    [drm:amdgpu_device_resize_fb_bar] *ERROR* Problem resizing BAR0 (-22).

Signed-off-by: Darren Salt <devspam at moreofthesa.me.uk>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 355fa0057c26..d80ba03913a7 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1136,6 +1136,8 @@ int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
 	r = pci_resize_resource(adev->pdev, 0, rbar_size);
 	if (r == -ENOSPC)
 		DRM_INFO("Not enough PCI address space for a large BAR.");
+	else if (r == -EINVAL)
+		DRM_INFO("VBIOS does not support exposing all VRAM via a large BAR.");
 	else if (r && r != -ENOTSUPP)
 		DRM_ERROR("Problem resizing BAR0 (%d).", r);
 
-- 
2.20.1



More information about the amd-gfx mailing list