[PATCH] drm/amd/pm: add pmfw version check before issuing RlcPowerNotify message

Huang Rui ray.huang at amd.com
Thu Dec 17 03:42:09 UTC 2020


On Thu, Dec 17, 2020 at 10:57:01AM +0800, Hou, Xiaomeng (Matthew) wrote:
> Only pmfw version behind v4.63.23.00 could support this message.
> 
> Signed-off-by: Xiaomeng Hou <Xiaomeng.Hou at amd.com>

Reviewed-by: Huang Rui <ray.huang at amd.com>

> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> index 9bccf2ad038c..8cb4fcee9a2c 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> @@ -724,8 +724,13 @@ static int vangogh_set_fine_grain_gfx_freq_parameters(struct smu_context *smu)
>  
>  static int vangogh_system_features_control(struct smu_context *smu, bool en)
>  {
> -	return smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
> -					en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
> +	struct amdgpu_device *adev = smu->adev;
> +
> +	if (adev->pm.fw_version >= 0x43f1700)
> +		return smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
> +						en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
> +	else
> +		return 0;
>  }
>  
>  static const struct pptable_funcs vangogh_ppt_funcs = {
> -- 
> 2.17.1
> 


More information about the amd-gfx mailing list