[PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

Paul Menzel pmenzel at molgen.mpg.de
Sat Dec 26 13:16:34 UTC 2020


Dear 李晨阳,


Am 26.12.20 um 09:56 schrieb Chenyang Li:
> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
> 
> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
> Signed-off-by: Chenyang Li <lichenyang at loongson.cn>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> index ee9480d14cbc..86cfb3d55477 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> @@ -21,7 +21,7 @@
>    *
>    */
>   
> -#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
> +#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
>   #define _AMDGPU_TRACE_H_
>   
>   #include <linux/stringify.h>

Reviewed-by: Paul Menzel <pmenzel at molgen.mpg.de>


Kind regards,

Paul


PS: Next time, for patch iterations, you should include the version in 
the tag: PATCH v2. The switch `-v` (`--reroll-count`) helps with that:

     git format-patch -1 -v 2


More information about the amd-gfx mailing list