[PATCH] drm/amdgpu/display: fix logic inversion in program_timing_sync()

[Alex Deucher]

Ping?

On Fri, Jan 10, 2020 at 3:11 PM Alex Deucher <alexdeucher at gmail.com> wrote:
>
> It looks like we should be reducing the group size when we don't
> have a plane rather than when we do.
>
> Bug: https://gitlab.freedesktop.org/drm/amd/issues/781
> Fixes: 5fc0cbfad45648 ("drm/amd/display: determine if a pipe is synced by plane state")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 3d89904003f0..01b27726d9c5 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1003,9 +1003,9 @@ static void program_timing_sync(
>                                 status->timing_sync_info.master = false;
>
>                 }
> -               /* remove any other pipes with plane as they have already been synced */
> +               /* remove any other pipes without plane as they have already been synced */
>                 for (j = j + 1; j < group_size; j++) {
> -                       if (pipe_set[j]->plane_state) {
> +                       if (!pipe_set[j]->plane_state) {
>                                 group_size--;
>                                 pipe_set[j] = pipe_set[group_size];
>                                 j--;
> --
> 2.24.1
>