[PATCH 2/2] drm/amdgpu:/navi10: use the ODCAP enum to index the caps array

Matt Coffin mcoffin13 at gmail.com
Sun Feb 9 22:03:13 UTC 2020


On 2/6/20 12:55 PM, Alex Deucher wrote:
> Rather than the FEATURE_ID flags.  Avoids a possible reading past
> the end of the array.

Just to make sure I understand, this has been broken the whole time,
right, and just happened to be working because we were only using the
lower-end values and happened to not read past the end of the array?

I'll do some testing for navi10, and play around with actually disabling
the capabilities manually to make sure we're responding correctly.

Thanks for fixing it!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200209/c5d27f8c/attachment.sig>


More information about the amd-gfx mailing list