[PATCH 4/6] drm/ttm: rework BO delayed delete.

Christian König ckoenig.leichtzumerken at gmail.com
Tue Feb 11 13:41:53 UTC 2020


[SNIP]
>>> +		/*
>>> +		 * Make NO_EVICT bos immediately available to
>>> +		 * shrinkers, now that they are queued for
>>> +		 * destruction.
>>> +		 */
>>> +		if (bo->mem.placement & TTM_PL_FLAG_NO_EVICT) {
>>> +			bo->mem.placement &= ~TTM_PL_FLAG_NO_EVICT;
>>> +			ttm_bo_move_to_lru_tail(bo, NULL);
>> [xh] this should be under lru lock.

Ah, yes good point.

>>
>>> +	BUG_ON(bo->mem.mm_node != NULL);
>>> +	ttm_tt_destroy(bo->ttm);
>> [xh] already destroy it in ttm_bo_cleanup_memtype_use.

Fixed as well.

Going to send that out with those two fixed in a minute.

Thanks,
Christian.


More information about the amd-gfx mailing list