[PATCH] drm/powerplay: Ratelimit PP_ASSERT warnings
Alex Deucher
alexdeucher at gmail.com
Wed Feb 12 15:59:27 UTC 2020
On Wed, Feb 12, 2020 at 9:39 AM Kent Russell <kent.russell at amd.com> wrote:
>
> In certain situations the message could be reported dozens-to-hundreds of
> times, based on how often the function is called.
> E.g. If MCLK DPM, any calls to get/set MCLK will result in a failure
> message, potentially flooding dmesg. Ratelimit the warnings to avoid
> this flood.
>
> Change-Id: Ib817fd9227e9ffec8f1ed18c5441cbb135bc413b
> Signed-off-by: Kent Russell <kent.russell at amd.com>
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> index 822cd8b5bf90..cea65093b6ad 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> @@ -37,7 +37,7 @@
> #define PP_ASSERT_WITH_CODE(cond, msg, code) \
> do { \
> if (!(cond)) { \
> - pr_warn("%s\n", msg); \
> + pr_warn_ratelimited("%s\n", msg); \
> code; \
> } \
> } while (0)
> @@ -45,7 +45,7 @@
> #define PP_ASSERT(cond, msg) \
> do { \
> if (!(cond)) { \
> - pr_warn("%s\n", msg); \
> + pr_warn_ratelimited("%s\n", msg); \
> } \
> } while (0)
>
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
More information about the amd-gfx
mailing list