[PATCH] drm/amdgpu: drop the non-sense firmware version check on arcturus

Christian König ckoenig.leichtzumerken at gmail.com
Mon Feb 17 11:06:50 UTC 2020


Am 17.02.20 um 11:32 schrieb Evan Quan:
> As the firmware versions of arcturus are different from other gfx9
> ASICs. And the warning("CP firmware version too old, please update!")
> caused by this check can be eliminated.
>
> Change-Id: I04ab0e435b6ff9712be502e6ebb8d6e1f0a776d8
> Signed-off-by: Evan Quan <evan.quan at amd.com>

Acked-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 9b7ff783e9a5..1c7a16b91686 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -1106,10 +1106,11 @@ static void gfx_v9_0_check_fw_write_wait(struct amdgpu_device *adev)
>   	adev->gfx.me_fw_write_wait = false;
>   	adev->gfx.mec_fw_write_wait = false;
>   
> -	if ((adev->gfx.mec_fw_version < 0x000001a5) ||
> +	if ((adev->asic_type != CHIP_ARCTURUS) &&
> +	    ((adev->gfx.mec_fw_version < 0x000001a5) ||
>   	    (adev->gfx.mec_feature_version < 46) ||
>   	    (adev->gfx.pfp_fw_version < 0x000000b7) ||
> -	    (adev->gfx.pfp_feature_version < 46))
> +	    (adev->gfx.pfp_feature_version < 46)))
>   		DRM_WARN_ONCE("CP firmware version too old, please update!");
>   
>   	switch (adev->asic_type) {



More information about the amd-gfx mailing list