[PATCH v2] drm/amdgpu: fix the wrong logic checking when secure buffer is created (v2)

[Nirmoy]

On 2/18/20 9:55 AM, Huang Rui wrote:
> On Tue, Feb 18, 2020 at 04:50:01PM +0800, Koenig, Christian wrote:
>> Am 18.02.20 um 09:30 schrieb Huang Rui:
>>> While the current amdgpu doesn't support TMZ, it will return the error if user
>>> mode would like to allocate secure buffer.
>>>
>>> Fixes: 17d907c drm/amdgpu: implement TMZ accessor (v3)
>>>
>>> v2: we didn't need this checking anymore.
>> You misunderstood me.
>>
> ok...
>
>>> Signed-off-by: Huang Rui <ray.huang at amd.com>
>>> ---
>>>    drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 5 -----
>>>    1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> index b51a060..5cbc63a 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> @@ -235,11 +235,6 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
>>>    	if (args->in.domains & ~AMDGPU_GEM_DOMAIN_MASK)
>>>    		return -EINVAL;
>>>    
>>> -	if (amdgpu_is_tmz(adev) && (flags & AMDGPU_GEM_CREATE_ENCRYPTED)) {
>>> -		DRM_ERROR("Cannot allocate secure buffer since TMZ is disabled\n");
>> Only the error message should be removed, but we still need to test the
>> flag.
>>
>> E.g. in general we should never log that userspace sends invalid parameters.
>>
> Why? It probably can help userspace to understand what wrong input it is.

May be we can use some rate limited logger here.

Nirmoy

>
> Thanks,
> Ray
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cnirmoy.das%40amd.com%7Cc022e81747e446bfe0c208d7b4504a56%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637176129272549986&sdata=drEDHkueArU6KVFCfUIcU3up%2FlmVhQRbXb7y2JZiSdE%3D&reserved=0