[PATCH] drm/amdgpu: fix the wrong logic checking when secure buffer is created

[Luben Tuikov]

On 2020-02-18 3:27 a.m., Huang Rui wrote:
> On Tue, Feb 18, 2020 at 04:04:15PM +0800, Koenig, Christian wrote:
>> Am 18.02.20 um 07:12 schrieb Huang Rui:
>>> While the current amdgpu doesn't support TMZ, it will return the error if user
>>> mode would like to allocate secure buffer.
>>>
>>> Fixes: 17d907c drm/amdgpu: implement TMZ accessor (v3)
>>>
>>> Signed-off-by: Huang Rui <ray.huang at amd.com>
>>
>> Reviewed-by: Christian König <christian.koenig at amd.com>
>>
>>> ---
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> index b51a060..91e4235 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> @@ -235,7 +235,7 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
>>>   	if (args->in.domains & ~AMDGPU_GEM_DOMAIN_MASK)
>>>   		return -EINVAL;
>>>   
>>> -	if (amdgpu_is_tmz(adev) && (flags & AMDGPU_GEM_CREATE_ENCRYPTED)) {
>>> +	if (!amdgpu_is_tmz(adev) && (flags & AMDGPU_GEM_CREATE_ENCRYPTED)) {
>>>   		DRM_ERROR("Cannot allocate secure buffer since TMZ is disabled\n");
>>
>> BTW: This message should be removed because it allows userspace to spam 
>> the logs.
>>
> 
> Fine. This can be removed.

I already submitted this for review, along with the flags bugfix.
???

What's going on????

Regards,
Luben


> 
> Thanks,
> Ray
> 
>>>   		return -EINVAL;
>>>   	}
>>