[PATCH] drm/amd/amdgpu: disable GFXOFF around debugfs access to MMIO

[Tom St Denis]

I got some messages after a while:

[  741.788564] Failed to send Message 8.
[  746.671509] Failed to send Message 8.
[  748.749673] Failed to send Message 2b.
[  759.245414] Failed to send Message 7.
[  763.216902] Failed to send Message 2a.

Are there any additional locks that should be held?  Because some 
commands like --top or --waves can do a lot of distinct read operations 
(causing a lot of enable/disable calls).

I'm going to sit on this a bit since I don't think the patch is ready 
for pushing out.


Tom

On 2020-02-19 10:07 a.m., Alex Deucher wrote:
> On Wed, Feb 19, 2020 at 10:04 AM Tom St Denis <tom.stdenis at amd.com> wrote:
>> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
> Please add a patch description.  With that fixed:
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>> index 7379910790c9..66f763300c96 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>> @@ -169,6 +169,7 @@ static int  amdgpu_debugfs_process_reg_op(bool read, struct file *f,
>>          if (pm_pg_lock)
>>                  mutex_lock(&adev->pm.mutex);
>>
>> +       amdgpu_gfx_off_ctrl(adev, false);
>>          while (size) {
>>                  uint32_t value;
>>
>> @@ -192,6 +193,8 @@ static int  amdgpu_debugfs_process_reg_op(bool read, struct file *f,
>>          }
>>
>>   end:
>> +       amdgpu_gfx_off_ctrl(adev, true);
>> +
>>          if (use_bank) {
>>                  amdgpu_gfx_select_se_sh(adev, 0xffffffff, 0xffffffff, 0xffffffff);
>>                  mutex_unlock(&adev->grbm_idx_mutex);
>> --
>> 2.24.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Ctom.stdenis%40amd.com%7Cf3c4cd3120fa476bbca808d7b54d8076%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637177216782684720&sdata=m5eyco1nGc5XD%2Ford7Q3goA48G5NhR%2BqdSYQjnfd7%2Fg%3D&reserved=0