[PATCH] drm/amdgpu: Add Arcturus D342 page retire support

[Chen, Guchun]

[AMD Public Use]

case CHIP_ARCTURUS:
+                           return __get_eeprom_i2c_addr_arct(adev, i2c_addr);
+                           break;

This 'break' is not needed. Please remove it.

Regards,
Guchun

From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Zhang, Hawking
Sent: Tuesday, February 25, 2020 6:42 PM
To: Clements, John <John.Clements at amd.com>; amd-gfx at lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Add Arcturus D342 page retire support


[AMD Official Use Only - Internal Distribution Only]

Please fix your coding style in the follow if/else code segment by removing the unnecessary {}. Other than that, the patch is

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>

+             if (strnstr(atom_ctx->vbios_version,
+                         "D342",
+                                 sizeof(atom_ctx->vbios_version)))
+             {
+                             *i2c_addr = EEPROM_I2C_TARGET_ADDR_ARCTURUS_D342;
+             }
+             else
+             {
+                             *i2c_addr = EEPROM_I2C_TARGET_ADDR_ARCTURUS;
+             }

Regards,
Hawking
From: Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>
Sent: Tuesday, February 25, 2020 17:58
To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>; Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>
Subject: [PATCH] drm/amdgpu: Add Arcturus D342 page retire support

Add support for detecting Arcturus SKU to resolve the correct bad page retirement EEPROM I2C address.

Thank you,
John Clements
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200225/6b73e269/attachment.htm>