[PATCH] drm/amdgpu: miss to remove pp_sclk file

Tao, Yintian Yintian.Tao at amd.com
Thu Feb 27 14:19:19 UTC 2020


Hi  Christian

Thanks a lot for your review


Hi  Alex


Can you help to review it? Thanks in advance.


Best Regards
Yintian Tao
-----Original Message-----
From: Koenig, Christian <Christian.Koenig at amd.com> 
Sent: 2020年2月27日 22:18
To: Tao, Yintian <Yintian.Tao at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>
Cc: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: miss to remove pp_sclk file

Am 27.02.20 um 15:11 schrieb Yintian Tao:
> Miss to remove pp_sclk file
>
> Signed-off-by: Yintian Tao <yttao at amd.com>

Looks reasonable to me, but Alex can probably better judge.

Acked-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index 9deff8cc9723..a43fc1c8ffd0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -3471,6 +3471,7 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev)
>   	device_remove_file(adev->dev, &dev_attr_pp_cur_state);
>   	device_remove_file(adev->dev, &dev_attr_pp_force_state);
>   	device_remove_file(adev->dev, &dev_attr_pp_table);
> +	device_remove_file(adev->dev, &dev_attr_pp_sclk);
>   
>   	device_remove_file(adev->dev, &dev_attr_pp_dpm_sclk);
>   	device_remove_file(adev->dev, &dev_attr_pp_dpm_mclk);



More information about the amd-gfx mailing list