[PATCH] drm/amdgpu: added function to wait for PSP BL availability

[Clements, John]

[AMD Public Use]

Good catch, I'll update my habit with this

From: Chen, Guchun <Guchun.Chen at amd.com>
Sent: Friday, January 3, 2020 4:33 PM
To: Clements, John <John.Clements at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>; amd-gfx at lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability


[AMD Public Use]

Thanks John.

+            for (retry_loop = 0; retry_loop < 10; retry_loop++)
+            {
The same coding style problem that "{" should not start at one new line. With this fixed, the patch is:
Reviewed-by: Guchun Chen <guchun.chen at amd.com<mailto:guchun.chen at amd.com>>

Regards,
Guchun

From: Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>
Sent: Friday, January 3, 2020 4:13 PM
To: Chen, Guchun <Guchun.Chen at amd.com<mailto:Guchun.Chen at amd.com>>; Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability


[AMD Official Use Only - Internal Distribution Only]

Hello GuChun,

I have updated the patch with your suggestion, and added back in the delay.

I can potentially investigate its removal in another patch

Thank you,
John Clements

From: Chen, Guchun <Guchun.Chen at amd.com<mailto:Guchun.Chen at amd.com>>
Sent: Friday, January 3, 2020 3:44 PM
To: Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>; Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability


[AMD Official Use Only - Internal Distribution Only]

-             /* there might be handshake issue with hardware which needs delay */
-             mdelay(20);

To be safety, I don't think we should remove this delay. And this actually do nothing with the code refine in this patch.

Regards,
Guchun

From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org<mailto:amd-gfx-bounces at lists.freedesktop.org>> On Behalf Of Clements, John
Sent: Friday, January 3, 2020 3:29 PM
To: Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Subject: [PATCH] drm/amdgpu: added function to wait for PSP BL availability


[AMD Official Use Only - Internal Distribution Only]

Added dedicated function to wait for PSP BL availability.

Increased driver wait time for PSP BL availability.

Thank you,
John Clements
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200103/b4157cca/attachment.htm>