[PATCH] drm/amdgpu/gfx: simplify old firmware warning
Christian König
ckoenig.leichtzumerken at gmail.com
Mon Jan 6 20:22:48 UTC 2020
Am 06.01.20 um 20:58 schrieb Alex Deucher:
> Put it on one line to avoid whitespace issues when
> printing in the log.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
Reviewed-by: Christian König <christian.koenig at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +--
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> index 5b05334a2548..379e46c1b7f6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> @@ -577,8 +577,7 @@ static void gfx_v10_0_check_fw_write_wait(struct amdgpu_device *adev)
> }
>
> if (adev->gfx.cp_fw_write_wait == false)
> - DRM_WARN_ONCE("Warning: check cp_fw_version and update it to realize \
> - GRBM requires 1-cycle delay in cp firmware\n");
> + DRM_WARN_ONCE("CP firmware version too old, please update!");
> }
>
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 35384f543664..1cae356b1ae0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -988,8 +988,7 @@ static void gfx_v9_0_check_fw_write_wait(struct amdgpu_device *adev)
> (adev->gfx.mec_feature_version < 46) ||
> (adev->gfx.pfp_fw_version < 0x000000b7) ||
> (adev->gfx.pfp_feature_version < 46))
> - DRM_WARN_ONCE("Warning: check cp_fw_version and update it to realize \
> - GRBM requires 1-cycle delay in cp firmware\n");
> + DRM_WARN_ONCE("CP firmware version too old, please update!");
>
> switch (adev->asic_type) {
> case CHIP_VEGA10:
More information about the amd-gfx
mailing list