[PATCH] drm/amdgpu: updated UMC error address record with correct channel index

[Chen, Guchun]

[AMD Public Use]

Reviewed-by: Guchun Chen <guchun.chen at amd.com>


From: Clements, John <John.Clements at amd.com>
Sent: Tuesday, January 7, 2020 4:32 PM
To: Chen, Guchun <Guchun.Chen at amd.com>; amd-gfx at lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: updated UMC error address record with correct channel index


[AMD Public Use]

Hello GuChun/Tao,

Thank you for your feedback, I have implemented both of your changes.

Thank you,
John Clements

From: Chen, Guchun <Guchun.Chen at amd.com<mailto:Guchun.Chen at amd.com>>
Sent: Tuesday, January 7, 2020 4:10 PM
To: Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: updated UMC error address record with correct channel index


[AMD Public Use]

If we have to improve the macro definition for repetitive loops, I assume we can merge the two defines into one, like:

#define LOOP_UMC_CH_INST(umc_inst) for ((umc_inst) = 0; (umc_inst) < adev->umc.umc_inst##_num; (umc_inst)++)

Then when we call the double loop, it can be done like:
LOOP_UMC_CH_INST(umc_inst)
              LOOP_UMC_CH_INST(channel_inst) {...

Next we should name the macro more friendly.

Regards,
Guchun

From: Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>
Sent: Tuesday, January 7, 2020 3:28 PM
To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>; dl.srdc_lnx_ras <dl.srdc_lnx_ras at amd.com<mailto:dl.srdc_lnx_ras at amd.com>>
Subject: [PATCH] drm/amdgpu: updated UMC error address record with correct channel index


[AMD Official Use Only - Internal Distribution Only]

Resolved issue with inputting an incorrect UMC channel index into the UMC error address record.

Defined macros for repetitive for loops

Thank you,
John Clements
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200107/47b7f40e/attachment-0001.htm>