[PATCH] drm/amdgpu: catch amdgpu_irq_add_id failure

Christian König christian.koenig at amd.com
Wed Jan 8 10:08:34 UTC 2020


Am 08.01.20 um 10:40 schrieb Nirmoy Das:
> Do not ignore amdgpu_irq_add_id return value while registering
> VMC page fault interrupt.
>
> Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>

Acked-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index da9765ff45d6..7dc8c068c62a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -720,6 +720,10 @@ static int gmc_v10_0_sw_init(void *handle)
>   	r = amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_VMC,
>   			      VMC_1_0__SRCID__VM_FAULT,
>   			      &adev->gmc.vm_fault);
> +
> +	if (r)
> +		return r;
> +
>   	r = amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_UTCL2,
>   			      UTCL2_1_0__SRCID__FAULT,
>   			      &adev->gmc.vm_fault);



More information about the amd-gfx mailing list