[PATCH 1/3] drm/amdgpu/display: set gpu vm flag for all asics which support it

Alex Deucher alexdeucher at gmail.com
Thu Jan 9 20:19:24 UTC 2020


On Thu, Jan 9, 2020 at 12:36 AM Huang Rui <ray.huang at amd.com> wrote:
>
> On Wed, Jan 08, 2020 at 05:49:08PM -0500, Alex Deucher wrote:
> > It won't get used unless the driver allows the gtt domain for
> > display buffers which is controlled elsewhere.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>
> Series are Acked-by: Huang Rui <ray.huang at amd.com>
>
> Any suggestion for testing, I would like to give a try in my renoir
> platform.

Thanks,  Aaron tested the first patch set which enabled GTT for
display and it didn't work on renoir, so that still needs additional
investigation before we can enable support for renoir.

Alex

>
> Thanks,
> Ray
>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++++++++------
> >  1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 1123f9ce86ee..fdf4d202ea1f 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -906,13 +906,15 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
> >
> >       init_data.dce_environment = DCE_ENV_PRODUCTION_DRV;
> >
> > -     /*
> > -      * TODO debug why this doesn't work on Raven
> > -      */
> > -     if (adev->flags & AMD_IS_APU &&
> > -         adev->asic_type >= CHIP_CARRIZO &&
> > -         adev->asic_type < CHIP_RAVEN)
> > +     switch (adev->asic_type) {
> > +     case CHIP_CARRIZO:
> > +     case CHIP_STONEY:
> > +     case CHIP_RAVEN:
> >               init_data.flags.gpu_vm_support = true;
> > +             break;
> > +     default:
> > +             break;
> > +     }
> >
> >       if (amdgpu_dc_feature_mask & DC_FBC_MASK)
> >               init_data.flags.fbc_support = true;
> > --
> > 2.24.1
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cray.huang%40amd.com%7C2abbd206df9a4078e3d208d7948d01b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637141205928856098&sdata=T%2Fetyq5T01NBu4x9l3jtZVC2%2BGwQv9z0KUlhJkxaa9I%3D&reserved=0


More information about the amd-gfx mailing list