[PATCH] drm/amdkfd: Fix a compiling warning

Felix Kuehling felix.kuehling at amd.com
Sat Jan 11 00:46:26 UTC 2020


On 2020-01-10 7:40 p.m., Yong Zhao wrote:
> The warning was introduced in
>
> commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e
> Author: Yong Zhao <Yong.Zhao at amd.com>
> Date:   Fri Dec 13 11:31:48 2019 -0500
>
>      drm/amdkfd: Improve function get_sdma_rlc_reg_offset()
>
> Change-Id: I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
> Signed-off-by: Yong Zhao <Yong.Zhao at amd.com>

Instead of quoting the whole change description, the usual way to point 
to a prior patch that you're fixing is with a tag

     Fixes: <12 digits of sha1> ("commit title")

With that fixed, this patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> index 2b26925623eb..f9011a07cb90 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> @@ -71,7 +71,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
>   				unsigned int engine_id,
>   				unsigned int queue_id)
>   {
> -	uint32_t sdma_engine_reg_base;
> +	uint32_t sdma_engine_reg_base = 0;
>   	uint32_t sdma_rlc_reg_offset;
>   
>   	switch (engine_id) {


More information about the amd-gfx mailing list