[PATCH RESEND] drm/amdgpu: error out on entity with no run queue

[Christian König]

Am 14.01.20 um 10:50 schrieb :
> Disabled HW IP's entity initialized with NULL rq. We should not
> process any submit request from userspace for a disabled HW IP.
>
> Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 614919f265b9..943e6075bdf9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -913,6 +913,11 @@ static int amdgpu_cs_ib_fill(struct amdgpu_device *adev,
>   		if (parser->entity && parser->entity != entity)
>   			return -EINVAL;
>   
> +		/* Return if there is no run queue associated with this entity.
> +		 * Possibly because of disabled HW IP*/
> +		if (entity->rq == NULL)
> +			return -EINVAL;
> +
>   		parser->entity = entity;
>   
>   		ring = to_amdgpu_ring(entity->rq->sched);