[PATCH] drm/amdgpu/display: Use u64 divide macro for round up division

Randy Dunlap rdunlap at infradead.org
Thu Jan 16 04:58:52 UTC 2020


On 1/13/20 9:07 AM, Ville Syrjälä wrote:
> On Mon, Jan 13, 2020 at 08:20:42AM -0500, mikita.lipski at amd.com wrote:
>> From: Mikita Lipski <mikita.lipski at amd.com>
>>
>> [why]
>> Fix compilation warnings on i386 architecture:
>> undefined reference to `__udivdi3'
>> [how]
>> Switch DIV_ROUND_UP to DIV64_U64_ROUND_UP
>>
>> Reported-by: Randy Dunlap <rdunlap at infradead.org>
>> Signed-off-by: Mikita Lipski <mikita.lipski at amd.com>
>> ---
>>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>> index 52fb207393ef..96b391e4b3e7 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>> @@ -534,7 +534,7 @@ static int kbps_to_peak_pbn(int kbps)
>>  
>>  	peak_kbps *= 1006;
>>  	peak_kbps = div_u64(peak_kbps, 1000);
>> -	return (int) DIV_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000));
>> +	return (int) DIV64_U64_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000));

that builds fine.

> DIV_ROUND_UP_ULL() would seem to suffice for this divisor.

and so does that one.

Thanks.

For either patch:
Acked-by: Randy Dunlap <rdunlap at infradead.org> # build-tested


 
>>  }
>>  
>>  static void set_dsc_configs_from_fairness_vars(struct dsc_mst_fairness_params *params,
>> -- 


-- 
~Randy



More information about the amd-gfx mailing list