[PATCH] drm/scheduler: fix documentation by replacing rq_list with sched_list
Nirmoy
nirmodas at amd.com
Fri Jan 17 10:59:23 UTC 2020
Hi Luben,
On 1/16/20 6:13 PM, Luben Tuikov wrote:
>> - * Note: the rq_list should have atleast one element to schedule
>> + * Note: the sched_list should have atleast one element to schedule
> "atleast" --> "at least".
Always a tricky one to catch, Thanks!
I will create a patch and ask Alex to squash with this one.
>
>> - * @num_rq_list: number of run queues in the rq_list
>> + * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
>> + * be scheduled
> I had to read this a few times to understand it. I wonder if splitting
> it into two sentences would make it clearer:
>
> "A list of schedulers (drm_gpu_schedulers). Jobs from this entity,
> can be scheduled on any scheduler on this list."
I don't know, both feels right to me. Please create a patch if you think
this splitting makes it more clearer.
Regards,
Nirmoy
More information about the amd-gfx
mailing list