[PATCH 1/2] drm/amdgpu: return EINVAL instead of ENOENT in the VM code

Luben Tuikov luben.tuikov at amd.com
Wed Jan 22 18:11:25 UTC 2020


Do we have user-space/libs rely on this errno in particular?

On 2020-01-22 9:03 a.m., Christian König wrote:
> That we can't find a PD above the root is expected can only happen if
> we try to update a larger range than actually managed by the VM.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 5cb182231f5d..8119f32ca94d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1475,7 +1475,7 @@ static int amdgpu_vm_update_ptes(struct amdgpu_vm_update_params *params,
>  			 * shift we should go up one level and check it again.
>  			 */
>  			if (!amdgpu_vm_pt_ancestor(&cursor))
> -				return -ENOENT;
> +				return -EINVAL;
>  			continue;
>  		}
>  
> 



More information about the amd-gfx mailing list