[PATCH] drm/amd/powerplay: use true, false for bool variable in smu7_hwmgr.c

Alex Deucher alexdeucher at gmail.com
Wed Jan 22 20:41:38 UTC 2020


On Wed, Jan 22, 2020 at 3:22 AM Zheng Bin <zhengbin13 at huawei.com> wrote:
>
> From: zhengbin <zhengbin13 at huawei.com>
>
> Fixes coccicheck warning:
>
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:723:2-50: WARNING: Assignment of 0/1 to bool variable
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:733:3-52: WARNING: Assignment of 0/1 to bool variable
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:747:3-51: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: zhengbin <zhengbin13 at huawei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index d70abad..bf04cfe 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -720,7 +720,7 @@ static int smu7_setup_dpm_tables_v0(struct pp_hwmgr *hwmgr)
>                 data->dpm_table.vddc_table.dpm_levels[i].value = allowed_vdd_mclk_table->entries[i].v;
>                 data->dpm_table.vddc_table.dpm_levels[i].param1 = std_voltage_table->entries[i].Leakage;
>                 /* param1 is for corresponding std voltage */
> -               data->dpm_table.vddc_table.dpm_levels[i].enabled = 1;
> +               data->dpm_table.vddc_table.dpm_levels[i].enabled = true;
>         }
>
>         data->dpm_table.vddc_table.count = allowed_vdd_sclk_table->count;
> @@ -730,7 +730,7 @@ static int smu7_setup_dpm_tables_v0(struct pp_hwmgr *hwmgr)
>                 /* Initialize Vddci DPM table based on allow Mclk values */
>                 for (i = 0; i < allowed_vdd_mclk_table->count; i++) {
>                         data->dpm_table.vddci_table.dpm_levels[i].value = allowed_vdd_mclk_table->entries[i].v;
> -                       data->dpm_table.vddci_table.dpm_levels[i].enabled = 1;
> +                       data->dpm_table.vddci_table.dpm_levels[i].enabled = true;
>                 }
>                 data->dpm_table.vddci_table.count = allowed_vdd_mclk_table->count;
>         }
> @@ -744,7 +744,7 @@ static int smu7_setup_dpm_tables_v0(struct pp_hwmgr *hwmgr)
>                  */
>                 for (i = 0; i < allowed_vdd_mclk_table->count; i++) {
>                         data->dpm_table.mvdd_table.dpm_levels[i].value = allowed_vdd_mclk_table->entries[i].v;
> -                       data->dpm_table.mvdd_table.dpm_levels[i].enabled = 1;
> +                       data->dpm_table.mvdd_table.dpm_levels[i].enabled = true;
>                 }
>                 data->dpm_table.mvdd_table.count = allowed_vdd_mclk_table->count;
>         }
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the amd-gfx mailing list