[PATCH] drm/amdgpu: allocate entities on demand

Nirmoy nirmodas at amd.com
Fri Jan 24 15:18:42 UTC 2020


On 1/24/20 1:56 PM, Christian König wrote:
>
>> +    entity->fences = kcalloc(amdgpu_sched_jobs,
>> +                 sizeof(struct dma_fence*), GFP_KERNEL);
>
> It would be rather nice to have to allocate the fences array together 
> with the entity.
>
> Take a look at struct dma_resv_list and the function 
> dma_resv_list_alloc() on how to do this.
>
That is very interesting allocation method.

Updated the patch.

Thanks,

Nirmoy

> Apart from that the patch now looks like a nice cleanup to me, but I 
> need to fully read it from top till bottom once more.
>
> Regards,
> Christian.
>


More information about the amd-gfx mailing list