[PATCH 1/5] drm/amdgpu: fix braces in amdgpu_vm_update_ptes

Felix Kuehling felix.kuehling at amd.com
Thu Jan 30 22:11:41 UTC 2020


On 2020-01-30 7:49, Christian König wrote:
> For the root PD mask can be 0xffffffff as well which would
> overrun to 0 if we don't cast it before we add one.
You're fixing parentheses, not braces.

Parentheses: ()
Brackets: []
Braces: {}

With the title fixed, this patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>

>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> Tested-by: Tom St Denis <tom.stdenis at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 5cb182231f5d..4ba6a5e5d094 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1487,7 +1487,7 @@ static int amdgpu_vm_update_ptes(struct amdgpu_vm_update_params *params,
>   		incr = (uint64_t)AMDGPU_GPU_PAGE_SIZE << shift;
>   		mask = amdgpu_vm_entries_mask(adev, cursor.level);
>   		pe_start = ((cursor.pfn >> shift) & mask) * 8;
> -		entry_end = (uint64_t)(mask + 1) << shift;
> +		entry_end = ((uint64_t)mask + 1) << shift;
>   		entry_end += cursor.pfn & ~(entry_end - 1);
>   		entry_end = min(entry_end, end);
>   


More information about the amd-gfx mailing list