[PATCH] drm/amdgpu: load ta firmware for sienna cichlid

[Clements, John]

[AMD Public Use]

Looks good to me Bhawanpreet,

If possible could you please also update the FW modules at the top of the source?
remove obsolete ASD path:
MODULE_FIRMWARE("amdgpu/sienna_cichlid_asd.bin");
Add TA path:
MODULE_FIRMWARE("amdgpu/sienna_cichlid_ta.bin");

Also for your information, there is a small bug in the  TA microcode init sequence that will prevent the TA FW from loading correctly, I'll submit a patch today to resolve it.

With above concerns resolved:
Reviewed-by: John Clements <John.Clements at amd.com>

-----Original Message-----
From: Alex Deucher <alexdeucher at gmail.com> 
Sent: Wednesday, July 15, 2020 3:40 AM
To: Lakha, Bhawanpreet <Bhawanpreet.Lakha at amd.com>
Cc: amd-gfx list <amd-gfx at lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher at amd.com>; Clements, John <John.Clements at amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas at amd.com>
Subject: Re: [PATCH] drm/amdgpu: load ta firmware for sienna cichlid

On Tue, Jul 14, 2020 at 3:16 PM Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com> wrote:
>
> call psp_int_ta_microcode() to parse the ta firmware.
>
> Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c 
> b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index 423386272920..798bc7b2db39 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -173,6 +173,9 @@ static int psp_v11_0_init_microcode(struct psp_context *psp)
>                 }
>                 break;
>         case CHIP_SIENNA_CICHLID:
> +               err = psp_init_ta_microcode(&adev->psp, chip_name);
> +               if (err)
> +                       return err;
>                 break;
>         default:
>                 BUG();
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cjo
> hn.clements%40amd.com%7Cc1b9c409e4f845c5a64808d8282dc590%7C3dd8961fe48
> 84e608e11a82d994e183d%7C0%7C0%7C637303524336189607&sdata=BN6utDBMk
> 8qgzY7b%2FOloi0yKQ9hmOHDjXlb3fw9fHio%3D&reserved=0