[PATCH] drm/amdgpu: resolve bug in ta microcode init

Chen, Guchun Guchun.Chen at amd.com
Wed Jul 15 07:01:12 UTC 2020


[AMD Public Use]

Hi John,

The patch is good. However, maybe it's better we can improve the patch commit message title/body together a bit.

Generally, original title 'resolve bug...' is not pretty clear to audience. If possible, we can modify the title to 'correct fw start address', and in message body, illustrate why the patch is needed.

With the comment addressed, the patch is:
Reviewed-by: Guchun Chen <guchun.chen at amd.com>

Regards,
Guchun

From: Clements, John <John.Clements at amd.com>
Sent: Wednesday, July 15, 2020 2:44 PM
To: amd-gfx list <amd-gfx at lists.freedesktop.org>; Lakha, Bhawanpreet <Bhawanpreet.Lakha at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>; Chen, Guchun <Guchun.Chen at amd.com>
Subject: [PATCH] drm/amdgpu: resolve bug in ta microcode init


[AMD Public Use]

Submitting patch for review to resolve bug when calculating FW offset within binaries with PSP TA v2 header.

Thank you,
John Clements
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200715/5da1fb9d/attachment.htm>


More information about the amd-gfx mailing list