[PATCH] drm/amdgpu: add RAS EEPROM support for sienna chichlid

[Clements, John]

[AMD Public Use]

Good points, I'll reorganize and resubmit the patch after Guchuns changes are in

From: Zhang, Hawking <Hawking.Zhang at amd.com>
Sent: Tuesday, July 21, 2020 7:11 PM
To: Clements, John <John.Clements at amd.com>; amd-gfx list <amd-gfx at lists.freedesktop.org>; Chen, Guchun <Guchun.Chen at amd.com>
Subject: RE: [PATCH] drm/amdgpu: add RAS EEPROM support for sienna chichlid


[AMD Public Use]

-              if (adev->asic_type != CHIP_VEGA20 && adev->asic_type != CHIP_ARCTURUS)
+             if (adev->asic_type != CHIP_VEGA20           &&
+                 adev->asic_type != CHIP_ARCTURUS         &&
+                 adev->asic_type != CHIP_SIENNA_CICHLID)
                               return 0;

Does it make sense to check UMC RAS availability through amdgpu_ras_is_supported, instead of check specific ASIC type one by one?

Also, it would be good to merge the upcoming logic from Guchun where we have a gloal flag to mark the availability of bad page retirement.

Thoughts?

Regards,
Hawking
From: Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>
Sent: Tuesday, July 21, 2020 18:02
To: amd-gfx list <amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>>; Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>
Subject: [PATCH] drm/amdgpu: add RAS EEPROM support for sienna chichlid


[AMD Public Use]

Submitting patch to enable RAS EEPROM support for sienna chichlid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200722/323b91fd/attachment.htm>