[PATCH 14/14] drm/amdgpu/gmc: disable keep_stolen_vga_memory on arcturus

Felix Kuehling felix.kuehling at amd.com
Tue Jul 28 23:28:59 UTC 2020


Am 2020-07-28 um 6:46 p.m. schrieb Alex Deucher:
> I suspect the only reason this was set was to avoid touching
> the display related registers on arcturus.  Someone should
> double check this on arcturus with S3.

Sounds reasonable, given that the other offenders here are all APUs.
AFAIK, we haven't tried S3 on Arcturus. Doesn't seem like something one
would do on a server.

See one more comment on patch 1. Other than that the series is

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>

Regards,
  Felix


>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index fc9e18aaa76e..0bd7b3797534 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -448,7 +448,6 @@ void amdgpu_gmc_get_vbios_allocations(struct amdgpu_device *adev)
>  	switch (adev->asic_type) {
>  	case CHIP_VEGA10:
>  	case CHIP_RAVEN:
> -	case CHIP_ARCTURUS:
>  	case CHIP_RENOIR:
>  		adev->gmc.keep_stolen_vga_memory = true;
>  		break;


More information about the amd-gfx mailing list