[PATCH 00/17] rework stolen pre-OS fb allocation handling (v2)

Christian König ckoenig.leichtzumerken at gmail.com
Thu Jul 30 09:14:13 UTC 2020


One comment on patch #17, apart from that the series is Reviewed-by: 
Christian König <christian.koenig at amd.com>.

Regards,
Christian.

Am 29.07.20 um 19:34 schrieb Alex Deucher:
> Split the allocations into two so we can still support the S3
> workarounds required on some platforms while also avoiding
> any artifacts when transitioning from bios to driver.
>
> In the future we could integrate handling of the ip discovery
> data and other vbios allocations into this helper function
> to consolidate handling of all of the vbios reservations.
>
> v2: Check if bo object is NULL rather than checking size
>      Move all vbios/firmware allocations into mman structure
>
> Alex Deucher (17):
>    drm/amdgpu: handle bo size 0 in amdgpu_bo_create_kernel_at (v2)
>    drm/amdgpu: use create_at for the stolen pre-OS buffer
>    drm/amdgpu: use a define for the memory size of the vga emulator
>    drm/amdgpu: move stolen vga bo from amdgpu to amdgpu.gmc
>    drm/amdgpu: move keep stolen memory check into gmc core
>    drm/amdgpu: add support for extended stolen vga memory
>    drm/amdgpu/gmc: add new helper to get the FB size used by pre-OS
>      console
>    drm/amdgpu/gmc6: switch to using amdgpu_gmc_get_vbios_allocations
>    drm/amdgpu/gmc7: switch to using amdgpu_gmc_get_vbios_allocations
>    drm/amdgpu/gmc8: switch to using amdgpu_gmc_get_vbios_allocations
>    drm/amdgpu/gmc9: switch to using amdgpu_gmc_get_vbios_allocations
>    drm/amdgpu/gmc10: switch to using amdgpu_gmc_get_vbios_allocations
>    drm/amdgpu: drop the CPU pointers for the stolen vga bos
>    drm/amdgpu/gmc: disable keep_stolen_vga_memory on arcturus
>    drm/amdgpu: move stolen memory from gmc to mman
>    drm/amdgpu: move IP discovery data to mman
>    drm/amdgpu: move vram usage by vbios to mman
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h           |  20 +--
>   drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c  |   4 +-
>   .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c  |   4 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   4 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c |  54 ++++----
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c       |  42 +++++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h       |   6 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c    |   3 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       |  64 ++++++----
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h       |  24 ++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c      |   6 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c        |  57 ++++-----
>   drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c         |   8 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c         |  11 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         |  11 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         | 119 ++++++------------
>   16 files changed, 226 insertions(+), 211 deletions(-)
>



More information about the amd-gfx mailing list