[PATCH] drm/amd/display: Only actually breakpoint if DEBUG_KERNEL_DC is enabled

Harry Wentland hwentlan at amd.com
Wed Jun 3 13:35:10 UTC 2020


On 2020-06-03 9:32 a.m., Nicholas Kazlauskas wrote:
> To match previous behavior and to not hang the kernel if someone
> accidentally builds with KGDB enabled.
> 
> Fixes: 4324a1752045 ("drm/amd/display: Make BREAK_TO_DEBUGGER() a debug print")
> 
> Cc: Harry Wentland <harry.wentland at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>

Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/os_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h
> index 604ceb6c0375..c3bbfe397e8d 100644
> --- a/drivers/gpu/drm/amd/display/dc/os_types.h
> +++ b/drivers/gpu/drm/amd/display/dc/os_types.h
> @@ -111,7 +111,7 @@
>  #define ASSERT(expr) WARN_ON_ONCE(!(expr))
>  #endif
>  
> -#if defined(CONFIG_HAVE_KGDB) || defined(CONFIG_KGDB)
> +#if defined(CONFIG_DEBUG_KERNEL_DC) && (defined(CONFIG_HAVE_KGDB) || defined(CONFIG_KGDB))
>  #define BREAK_TO_DEBUGGER() \
>  	do { \
>  		DRM_DEBUG_DRIVER("%s():%d\n", __func__, __LINE__); \
> 


More information about the amd-gfx mailing list