[PATCH 25/28] drm/amd/display: not reset dmub in driver.

Qingqing Zhuo qingqing.zhuo at amd.com
Mon Jun 8 04:59:23 UTC 2020

From: Yongqiang Sun <yongqiang.sun at amd.com>

during S0i3, set power state is toggled a few times,
and dmub uC will restart with current reset/hw_init.

Remove reset in set power state, and before doing hw_init,
check if dmub is enabled, and doing FW autoload check only
if dmub is already enabled.

Signed-off-by: Yongqiang Sun <yongqiang.sun at amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng at amd.com>
Acked-by: Qingqing Zhuo <qingqing.zhuo at amd.com>
 drivers/gpu/drm/amd/display/dmub/src/dmub_dcn20.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn20.c b/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn20.c
index 1e03f6fdabd6..2c4a2fe9311d 100644
--- a/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn20.c
+++ b/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn20.c
@@ -275,7 +275,11 @@ void dmub_dcn20_set_inbox1_wptr(struct dmub_srv *dmub, uint32_t wptr_offset)
 bool dmub_dcn20_is_hw_init(struct dmub_srv *dmub)
+	uint32_t is_hw_init;
+	return is_hw_init != 0;
 bool dmub_dcn20_is_supported(struct dmub_srv *dmub)

More information about the amd-gfx mailing list