[PATCH] drm/amd: remove unnecessary conversion to bool

Alex Deucher alexdeucher at gmail.com
Fri Jun 12 15:24:42 UTC 2020


On Fri, Jun 12, 2020 at 9:22 AM Bernard Zhao <bernard at vivo.com> wrote:
>
> In function is_support_sw_smu, remove unnecessary conversion
> to bool return, this change is to make the code a bit readable.
>
> Signed-off-by: Bernard Zhao <bernard at vivo.com>

Vega20 support was removed from this code path so the patch is no
longer relevant.

Thanks,

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 8c684a6e0156..3e1cfb010378 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -568,7 +568,7 @@ int smu_update_table(struct smu_context *smu, enum smu_table_id table_index, int
>  bool is_support_sw_smu(struct amdgpu_device *adev)
>  {
>         if (adev->asic_type == CHIP_VEGA20)
> -               return (amdgpu_dpm == 2) ? true : false;
> +               return (amdgpu_dpm == 2);
>         else if (adev->asic_type >= CHIP_ARCTURUS) {
>               if (amdgpu_sriov_is_pp_one_vf(adev) || !amdgpu_sriov_vf(adev))
>                         return true;
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list