[PATCH] drm/amdgpu: remove perf level dpm in one-VF

[Wang, Kevin(Yang)]

[AMD Official Use Only - Internal Distribution Only]

please add these smu messages into patch commit,
after fixed,
Reviewed-by: Kevin Wang <kevin1.wang at amd.com>

Best Regards,
Kevin
________________________________
From: Sheng, Wenhui <Wenhui.Sheng at amd.com>
Sent: Sunday, June 14, 2020 3:38 PM
To: Wang, Kevin(Yang) <Kevin1.Wang at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: remove perf level dpm in one-VF


[AMD Official Use Only - Internal Distribution Only]


[AMD Official Use Only - Internal Distribution Only]



Hi Kevin,



At least 3  SMU messages not supported in one-VF mode , which could break the node power_dpm_force_performance_level functionality



SMU_MSG_SetSoftMaxByFreq
SMU_MSG_SetSoftMinByFreq

SMU_MSG_TransferTableDram2Smu



Brs

Wenhui

From: Wang, Kevin(Yang) <Kevin1.Wang at amd.com>
Sent: Friday, June 12, 2020 7:04 PM
To: Sheng, Wenhui <Wenhui.Sheng at amd.com>; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: remove perf level dpm in one-VF



[AMD Official Use Only - Internal Distribution Only]



which smu message will break this node work on navi12 asic?



Best Regards,

Kevin

________________________________

From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org<mailto:amd-gfx-bounces at lists.freedesktop.org>> on behalf of Wenhui Sheng <Wenhui.Sheng at amd.com<mailto:Wenhui.Sheng at amd.com>>
Sent: Friday, June 12, 2020 5:30 PM
To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> <amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>>
Cc: Sheng, Wenhui <Wenhui.Sheng at amd.com<mailto:Wenhui.Sheng at amd.com>>
Subject: [PATCH] drm/amdgpu: remove perf level dpm in one-VF



On Navi12 platform, node power_dpm_force_performance_level
doesn't work correctly in one-VF mode.

Signed-off-by: Wenhui Sheng <Wenhui.Sheng at amd.com<mailto:Wenhui.Sheng at amd.com>>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index 395ddbe2461c..4e7b579afe0b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
@@ -1877,7 +1877,7 @@ static ssize_t amdgpu_set_thermal_throttling_logging(struct device *dev,

 static struct amdgpu_device_attr amdgpu_device_attrs[] = {
         AMDGPU_DEVICE_ATTR_RW(power_dpm_state,                          ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
-       AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level,        ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+       AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level,        ATTR_FLAG_BASIC),
         AMDGPU_DEVICE_ATTR_RO(pp_num_states,                            ATTR_FLAG_BASIC),
         AMDGPU_DEVICE_ATTR_RO(pp_cur_state,                             ATTR_FLAG_BASIC),
         AMDGPU_DEVICE_ATTR_RW(pp_force_state,                           ATTR_FLAG_BASIC),
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7C76d3cddef9744f5c7ee908d80eb3502e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637275511045991505&sdata=1uvfK9R%2FMAFkZrgPk5aEnVMQs9zYOJQUFdLWwLzMbs4%3D&reserved=0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200615/aad1cf12/attachment.htm>