[PATCH] drm/amd/powerplay: declare driver if version mismatch as "warning" explicitly

[Alex Deucher]

On Wed, Jun 17, 2020 at 5:45 AM Evan Quan <evan.quan at amd.com> wrote:
>
> So that user knows it's just a warning and can be safely ignored.

I'm not sure I follow this logic.  I think a warning would cause more
concern than just printing it as info.  Why would you ignore a
warning?

Alex

>
> Change-Id: Ic518ec3eb68c6bd6682e6131e32cfe90843341ff
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> index 2bcb8d16f1b7..22eabc10ea8e 100644
> --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> @@ -318,11 +318,11 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)
>          * of halt driver loading.
>          */
>         if (if_version != smu->smc_driver_if_version) {
> -               dev_info(smu->adev->dev, "smu driver if version = 0x%08x, smu fw if version = 0x%08x, "
> +               dev_warn(smu->adev->dev, "warning: smu driver if version = 0x%08x, smu fw if version = 0x%08x, "
>                         "smu fw version = 0x%08x (%d.%d.%d)\n",
>                         smu->smc_driver_if_version, if_version,
>                         smu_version, smu_major, smu_minor, smu_debug);
> -               dev_warn(smu->adev->dev, "SMU driver if version not matched\n");
> +               dev_warn(smu->adev->dev, "warning: SMU driver if version not matched\n");
>         }
>
>         return ret;
> --
> 2.27.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx