[PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig

Alex Deucher alexdeucher at gmail.com
Fri Jun 19 15:27:14 UTC 2020


On Thu, Jun 18, 2020 at 3:49 PM Qingqing Zhuo <qingqing.zhuo at amd.com> wrote:
>
> when compiled with allmodconfig option, there are error
> messages as below:
>
> ERROR: modpost:
> "mod_color_is_table_init"
> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: modpost:
> "mod_color_get_table"
> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: modpost:
> "mod_color_set_table_init_state"
> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>
> To fix the issue, this commits removes
> CONFIG_DRM_AMD_DC_DCN guard in color/makefile.
>
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo at amd.com>
> CC: Lewis Huang <Lewis.Huang at amd.com>
> CC: Aric Cyr <Aric.Cyr at amd.com>
> CC: Alexander Deucher <Alexander.Deucher at amd.com>
> CC: Harry Wentland <hwentlan at amd.com>
> CC: Nicholas Kazlauskas <Nicholas.Kazlauskas at amd.com>
> CC: Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com>
> CC: Stephen Rothwell <sfr at canb.auug.org.au>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/display/modules/color/Makefile | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/color/Makefile b/drivers/gpu/drm/amd/display/modules/color/Makefile
> index 3ee7f27ff93b..e66c19a840c2 100644
> --- a/drivers/gpu/drm/amd/display/modules/color/Makefile
> +++ b/drivers/gpu/drm/amd/display/modules/color/Makefile
> @@ -23,11 +23,7 @@
>  # Makefile for the color sub-module of DAL.
>  #
>
> -MOD_COLOR = color_gamma.o
> -
> -ifdef CONFIG_DRM_AMD_DC_DCN
> -MOD_COLOR += color_table.o
> -endif
> +MOD_COLOR = color_gamma.o color_table.o
>
>  AMD_DAL_MOD_COLOR = $(addprefix $(AMDDALPATH)/modules/color/,$(MOD_COLOR))
>  #$(info ************  DAL COLOR MODULE MAKEFILE ************)
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list