[PATCH v2 2/3] drm/amdgpu: Inform user about effect of running without DPM
Paul Menzel
pmenzel at molgen.mpg.de
Fri Jun 19 18:50:08 UTC 2020
Currently, most users have no idea about the effects of failed DPM
initialization. So add it to the log message.
Signed-off-by: Paul Menzel <pmenzel at molgen.mpg.de>
---
drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 2 +-
drivers/gpu/drm/amd/amdgpu/si_dpm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
index b179bdc17cdc..f054ded902f2 100644
--- a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
+++ b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
@@ -3033,7 +3033,7 @@ static int kv_dpm_sw_init(void *handle)
dpm_failed:
kv_dpm_fini(adev);
mutex_unlock(&adev->pm.mutex);
- drm_err(adev, "amdgpu: dpm initialization failed\n");
+ drm_err(adev, "amdgpu: dpm initialization failed. Clocks set up by firmware will be used. Most likely they are low, so performance might suffer.\n");
return ret;
}
diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/drm/amd/amdgpu/si_dpm.c
index 8ba673ca2f5e..f7edc1d50df4 100644
--- a/drivers/gpu/drm/amd/amdgpu/si_dpm.c
+++ b/drivers/gpu/drm/amd/amdgpu/si_dpm.c
@@ -7710,7 +7710,7 @@ static int si_dpm_sw_init(void *handle)
dpm_failed:
si_dpm_fini(adev);
mutex_unlock(&adev->pm.mutex);
- drm_err(adev, "amdgpu: dpm initialization failed\n");
+ drm_err(adev, "amdgpu: dpm initialization failed. Clocks set up by firmware will be used. Most likely they are low, so performance might suffer.\n");
return ret;
}
--
2.27.0
More information about the amd-gfx
mailing list