[PATCH 1/1] drm/powerplay: fix compilation warning

Alex Deucher alexdeucher at gmail.com
Mon Jun 22 20:09:06 UTC 2020


On Mon, Jun 22, 2020 at 3:55 PM Nirmoy Das <nirmoy.aiemd at gmail.com> wrote:
>
> If (smu)->ppt_funcs->intf is not initialized then
> smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumBottom32, &bottom32) and
> smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumTop32, &top32) will not
> touch bottom32 and top32.
>
> Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> index b27d0b18eafa..d93f8a43a96f 100644
> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> @@ -2371,7 +2371,7 @@ static void arcturus_i2c_eeprom_control_fini(struct smu_context *smu, struct i2c
>  static void arcturus_get_unique_id(struct smu_context *smu)
>  {
>         struct amdgpu_device *adev = smu->adev;
> -       uint32_t top32, bottom32, smu_version;
> +       uint32_t top32 = 0, bottom32 = 0, smu_version;
>         uint64_t id;
>
>         if (smu_get_smc_version(smu, NULL, &smu_version)) {
> --
> 2.27.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list