[PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom
Mikel Rychliski
mikel at mikelr.com
Wed Mar 4 03:20:45 UTC 2020
On Tuesday, March 3, 2020 9:38:27 AM EST Bjorn Helgaas wrote:
> Cosmetics:
>
> s/ioremap/ioremap()/ (also in commit log)
> s/phys_to_virt/phys_to_virt()/ (also in commit log)
> s/pci_platform_rom/pci_platform_rom()/ (commit log)
> s/rom/ROM/
> This changes the interface of pci_platform_rom() (the caller is now
> responsible for doing an iounmap()). That should be mentioned in the
> function comment, and I think the subsequent patches should be
> squashed into this one so the interface change and the caller changes
> are done simultaneously.
>
> Also, it looks like nvbios_platform.init() (platform_init()) needs a
> similar change?
Hi Bjorn,
Thank you for your comments. I'll make the suggested changes, add an iounmap()
in the nouveau usage, and provide a new two-patch series.
More information about the amd-gfx
mailing list