[PATCH] drm/amdgpu: Wrap clflush_cache_range with x86 ifdef

Deucher, Alexander Alexander.Deucher at amd.com
Wed Mar 4 18:28:56 UTC 2020


[AMD Public Use]

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
________________________________
From: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
Sent: Wednesday, March 4, 2020 1:08 PM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Grodzovsky, Andrey <Andrey.Grodzovsky at amd.com>
Subject: [PATCH] drm/amdgpu: Wrap clflush_cache_range with x86 ifdef

To avoid compile errors on other platforms.

Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index cff0fd2..3836acc 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -1883,8 +1883,15 @@ static ssize_t psp_usbc_pd_fw_sysfs_write(struct device *dev,

         memcpy_toio(cpu_addr, usbc_pd_fw->data, usbc_pd_fw->size);

-       /*TODO Remove once PSP starts snooping CPU cache */
+       /*
+        * x86 specific workaround.
+        * Without it the buffer is invisible in PSP.
+        *
+        * TODO Remove once PSP starts snooping CPU cache
+        */
+#ifdef CONFIG_X86
         clflush_cache_range(cpu_addr, (usbc_pd_fw->size & ~(L1_CACHE_BYTES - 1)));
+#endif

         mutex_lock(&adev->psp.mutex);
         ret = psp_load_usbc_pd_fw(&adev->psp, dma_addr);
--
2.7.4

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200304/2f8a2d51/attachment-0001.htm>


More information about the amd-gfx mailing list