[PATCH] drm/amd/powerplay: fix the coverity warning about negative check for an unsigned value

Quan, Evan Evan.Quan at amd.com
Tue Mar 10 03:15:49 UTC 2020


Reviewed-by: Evan Quan <evan.quan at amd.com>

-----Original Message-----
From: Liang, Prike <Prike.Liang at amd.com> 
Sent: Tuesday, March 10, 2020 8:36 AM
To: amd-gfx at lists.freedesktop.org; Quan, Evan <Evan.Quan at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>
Cc: Liang, Prike <Prike.Liang at amd.com>
Subject: [PATCH] drm/amd/powerplay: fix the coverity warning about negative check for an unsigned value

There will be a coverity warning because min and max are both unsigned.

Signed-off-by: Prike Liang <Prike.Liang at amd.com>
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index d454493..f18e3fa 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -214,9 +214,6 @@ int smu_set_soft_freq_range(struct smu_context *smu, enum smu_clk_type clk_type,  {
 	int ret = 0;
 
-	if (min < 0 && max < 0)
-		return -EINVAL;
-
 	if (!smu_clk_dpm_is_enabled(smu, clk_type))
 		return 0;
 
--
2.7.4



More information about the amd-gfx mailing list