[PATCH RESEND v2 2/2] PCI: Use ioremap(), not phys_to_virt() for platform ROM

Christoph Hellwig hch at infradead.org
Wed Mar 18 06:51:19 UTC 2020


On Tue, Mar 17, 2020 at 09:34:33PM -0400, Mikel Rychliski wrote:
> I think the direct access to pdev->rom you suggest makes sense, especially 
> because users of the pci_platform_rom() are exposed to the fact that it just 
> calls ioremap().
> 
> I decided against wrapping the iounmap() with a pci_unmap_platform_rom(), but 
> I didn't apply the same consideration to the existing function.
> 
> How about something like this (with pci_platform_rom() removed)?

That looks sensible to me.


More information about the amd-gfx mailing list