[PATCH] drm/amdgpu: disabled fru eeprom access

[Zhang, Hawking]

[AMD Official Use Only - Internal Distribution Only]

Never mind, I noticed you added the check in amdgpu_fru_get_product_info. Then I think it's safe to remove the check from amdgpu_fru_read_eeprom. Other than that, the patch is

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>

Regards,
Hawking

From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Zhang, Hawking
Sent: Monday, March 23, 2020 17:09
To: Clements, John <John.Clements at amd.com>; amd-gfx at lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: disabled fru eeprom access


[AMD Official Use Only - Internal Distribution Only]

Hi John,

How about adding the shell function at the beginning of amdgpu_fru_get_product_info. It make sense to me to check the FRU eeprom availability before access. But having the check in amdgpu_fru_read_eeprom would results to unnecessary drm error message for all the following access in amdgpu_fru_get_product_info.

Regards,
Hawking
From: Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>
Sent: Monday, March 23, 2020 16:51
To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>; Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>
Subject: [PATCH] drm/amdgpu: disabled fru eeprom access


[AMD Official Use Only - Internal Distribution Only]

Submitting patch to:

  *   Disable FRU EEPROM access by default
  *   Add shell function to be used for supported device detection

Thank you,
John Clements
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200323/e3b5284e/attachment-0001.htm>