[PATCH v2 hmm 2/9] mm/hmm: return the fault type from hmm_pte_need_fault()

Christoph Hellwig hch at lst.de
Sat Mar 28 08:10:06 UTC 2020


On Fri, Mar 27, 2020 at 05:00:14PM -0300, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg at mellanox.com>
> 
> Using two bools instead of flags return is not necessary and leads to
> bugs. Returning a value is easier for the compiler to check and easier to
> pass around the code flow.
> 
> Convert the two bools into flags and push the change to all callers.
> 
> Signed-off-by: Jason Gunthorpe <jgg at mellanox.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>


More information about the amd-gfx mailing list